-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
demonstrate how to cp source tarballs to add in rspm #283
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting! Thanks for writing this up! I'll have to take a more careful read through the docs.
One question: what are your thoughts around docker cp
and whether that would more neatly solve the problem without having to add another volume and the overhead, confusion, and permissions issues that volumes can create when written from the host and read from the container? (IIRC volumes can be a notorious troublesome spot in linux, as well as in certain versions / configurations of docker desktop for mac)
my thoughts are - oh nice! I've never used that 😎 Lemme give that a whirl. The case that I can think of that I want to make sure doesn't get wonky is we'd need the guidance to prob match up to copy into /data so the tarball will still ultimately land in the persistent dir, else if you docker-compose down then the db/everything else expecting the tarball would still live on and then might go sideways on start up next time. I concur that keeping things as simple as possible especially around what crosses the host boundaries is ideal. |
Nice! It's worth noting that RSPM also "caches" the tarball, so once you have imported it, you can actually dispense with it 😄 We don't make that very clear in our docs, as far as I can tell, but if you are persisting the database and the data directory then there is really no need to keep track of the tarball - ephemeral storage is just fine 😄 |
that is definitely an interesting tidbit to know! |
round 2 - trying flow with docker cp: built demo1 pkg in the rsw container: we see demo1_0.1.0.tar.gz kicked out in data/rsw/rstudio
find container id:
copy from host into rspm image:
cool deal its there:
and looks like we're in business: |
@colearendt |
The result of following the instructions in the
package-manager/README.me
will result in a new demopkgs repo created: